Refactor Str::pool method.

2011-07-07 07:16:20 -07:00 · 2011-07-07 07:16:20 -07:00 · 5755fdaba0
parent c50246c694
commit 5755fdaba0
1 changed files with 6 additions and 10 deletions
--- a/system/str.php
+++ b/system/str.php
@ -88,18 +88,14 @@ public static function random($length = 16, $type = 'alnum')
     */
    private static function pool($type = 'alnum')
    {
-        if ($type == 'alnum')
+        switch ($type)
        {
+            case 'alnum':
                return '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
-        }
-        elseif ($type == 'alpha')
-        {
+            
+            default:
                return 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
        }
-        else
-        {
-            throw new \Exception("Unrecognized random pool [$type].");
-        }
    }

 }