Refactoring Str class.

system/str.php

@@ -70,28 +70,8 @@ public static function random($length = 16, $type = 'alnum')
     {
         $value = '';
 
-        // -----------------------------------------------------
+        $pool_length = strlen($pool = static::pool($type)) - 1;
-        // Get the proper character pool for the type.
-        // -----------------------------------------------------
-        switch ($type)
-        {
-            case 'alpha':
-                $pool = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
-                break;
 
-            default:
-                $pool = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
-        }
-
-        // -----------------------------------------------------
-        // Get the pool length and split the pool into an array.
-        // -----------------------------------------------------
-        $pool_length = strlen($pool) - 1;
-        $pool = str_split($pool, 1);
-
-        // -----------------------------------------------------
-        // Build the random string to the specified length.
-        // -----------------------------------------------------
         for ($i = 0; $i < $length; $i++)
         {
             $value .= $pool[mt_rand(0, $pool_length)];
@@ -100,4 +80,26 @@ public static function random($length = 16, $type = 'alnum')
         return $value;
     }
 
+    /**
+     * Get a chracter pool.
+     *
+     * @param  string  $type
+     * @return string
+     */
+    private static function pool($type = 'alnum')
+    {
+        if ($type == 'alnum')
+        {
+            return '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
+        }
+        elseif ($type == 'alpha')
+        {
+            return 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ';
+        }
+        else
+        {
+            throw new \Exception("Unrecognized random pool [$type].");
+        }
+    }
+
 }