refactoring route loader and router.

This commit is contained in:
Taylor Otwell 2011-09-20 00:07:16 -05:00
parent 82f3784d2b
commit 096280c958
3 changed files with 22 additions and 30 deletions

View File

@ -64,31 +64,25 @@ public function load($uri)
*/ */
protected function nested($segments) protected function nested($segments)
{ {
$routes = array();
// Work backwards through the URI segments until we find the deepest possible // Work backwards through the URI segments until we find the deepest possible
// matching route directory. Once we find it, we will return those routes. // matching route directory. Once we find it, we will return those routes.
foreach (array_reverse($segments, true) as $key => $value) foreach (array_reverse($segments, true) as $key => $value)
{ {
// First we check to determine if there is a route file matching the segment
// of the URI. If there is, its routes will be merged into the route array.
if (file_exists($path = $this->nest.implode('/', array_slice($segments, 0, $key + 1)).EXT)) if (file_exists($path = $this->nest.implode('/', array_slice($segments, 0, $key + 1)).EXT))
{ {
$routes = array_merge($routes, require $path); return require $path;
} }
// Even if we have already loaded routes for the URI, we still want to check // Even if we didn't find a matching file for the segment, we still want to
// for a "routes.php" file which could handle the root route and any routes // check for a "routes.php" file which could handle the root route and any
// that are impossible to handle in an explicitly named file. // routes that are impossible to handle in an explicitly named file.
if (file_exists($path = str_replace('.php', '/routes.php', $path))) if (file_exists($path = str_replace('.php', '/routes.php', $path)))
{ {
$routes = array_merge($routes, require $path); return require $path;
}
} }
if (count($routes) > 0) return $routes; return array();
}
return $routes;
} }
/** /**
@ -105,9 +99,15 @@ public function everything()
$routes = array(); $routes = array();
// First we will check for the base routes file in the application directory.
if (file_exists($path = $this->base.'routes'.EXT))
{
$routes = array_merge($routes, require $path);
}
// Since route files can be nested deep within the route directory, we need to // Since route files can be nested deep within the route directory, we need to
// recursively spin through each directory to find every file. // recursively spin through each directory to find every file.
$recursiveIterator = new Iterator(new DirectoryIterator($this->nest), Iterator::SELF_FIRST); $iterator = new Iterator(new DirectoryIterator($this->nest), Iterator::SELF_FIRST);
foreach ($iterator as $file) foreach ($iterator as $file)
{ {

View File

@ -48,19 +48,18 @@ public function __construct(Loader $loader, $controllers)
*/ */
public function find($name) public function find($name)
{ {
// First we will check the cache of route names. If we have already found the given route,
// we will simply return that route from the cache to improve performance.
if (array_key_exists($name, $this->names)) return $this->names[$name]; if (array_key_exists($name, $this->names)) return $this->names[$name];
$arrayIterator = new \RecursiveArrayIterator($this->loader->everything()); // Spin through every route defined for the application searching for a route that has
// a name matching the name passed to the method. If the route is found, it will be
$recursiveIterator = new \RecursiveIteratorIterator($arrayIterator); // cached in the array of named routes and returned.
foreach ($this->loader->everything() as $key => $value)
foreach ($recursiveIterator as $iterator)
{ {
$route = $recursiveIterator->getSubIterator(); if (is_array($value) and isset($value['name']) and $value['name'] === $name)
if (isset($route['name']) and $route['name'] === $name)
{ {
return $this->names[$name] = array($arrayIterator->key() => iterator_to_array($route)); return $this->names[$name] = array($key => $value);
} }
} }
} }

View File

@ -15,11 +15,6 @@
*/ */
define('START_TIME', microtime(true)); define('START_TIME', microtime(true));
function elapsed()
{
return number_format((microtime(true) - START_TIME) * 1000, 2);
}
/* /*
|-------------------------------------------------------------------------- |--------------------------------------------------------------------------
| Laravel Installation Paths | Laravel Installation Paths
@ -49,5 +44,3 @@ function elapsed()
|-------------------------------------------------------------------------- |--------------------------------------------------------------------------
*/ */
require $laravel.'/laravel.php'; require $laravel.'/laravel.php';
echo elapsed();