fixed bugs found when unit testing.
This commit is contained in:
parent
9caf239f6b
commit
895d876463
|
@ -14,14 +14,14 @@ class Response {
|
||||||
*
|
*
|
||||||
* @var int
|
* @var int
|
||||||
*/
|
*/
|
||||||
protected $status;
|
public $status;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The response headers.
|
* The response headers.
|
||||||
*
|
*
|
||||||
* @var array
|
* @var array
|
||||||
*/
|
*/
|
||||||
protected $headers = array();
|
public $headers = array();
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* HTTP status codes.
|
* HTTP status codes.
|
||||||
|
|
|
@ -28,9 +28,9 @@ abstract class Controller {
|
||||||
* For example, a destination of "user.profile@show" would call the User_Profile
|
* For example, a destination of "user.profile@show" would call the User_Profile
|
||||||
* controller's show method with the given parameters.
|
* controller's show method with the given parameters.
|
||||||
*
|
*
|
||||||
* @param string $destination
|
* @param string $destination
|
||||||
* @param array $parameters
|
* @param array $parameters
|
||||||
* @return mixed
|
* @return Response
|
||||||
*/
|
*/
|
||||||
public static function call($destination, $parameters = array())
|
public static function call($destination, $parameters = array())
|
||||||
{
|
{
|
||||||
|
@ -43,30 +43,12 @@ public static function call($destination, $parameters = array())
|
||||||
|
|
||||||
$controller = static::resolve($controller);
|
$controller = static::resolve($controller);
|
||||||
|
|
||||||
if (is_null($controller) or static::hidden($method))
|
if (is_null($controller))
|
||||||
{
|
{
|
||||||
return Response::error('404');
|
return Response::error('404');
|
||||||
}
|
}
|
||||||
|
|
||||||
// Again, as was the case with route closures, if the controller
|
return $controller->execute($method, $parameters);
|
||||||
// "before" filters return a response, it will be considered the
|
|
||||||
// response to the request and the controller method will not be
|
|
||||||
// used to handle the request to the application.
|
|
||||||
$response = Filter::run($controller->filters('before'), array(), true);
|
|
||||||
|
|
||||||
if (is_null($response))
|
|
||||||
{
|
|
||||||
$response = call_user_func_array(array($controller, $method), $parameters);
|
|
||||||
}
|
|
||||||
|
|
||||||
// The after filter and the framework expects all responses to
|
|
||||||
// be instances of the Response class. If the method did not
|
|
||||||
// return an instsance of Response, we will make on now.
|
|
||||||
if ( ! $response instanceof Response) $response = new Response($response);
|
|
||||||
|
|
||||||
Filter::run($controller->filters('after'), array($response));
|
|
||||||
|
|
||||||
return $response;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -106,7 +88,7 @@ protected static function load($controller)
|
||||||
|
|
||||||
if (file_exists($path = CONTROLLER_PATH.$controller.EXT))
|
if (file_exists($path = CONTROLLER_PATH.$controller.EXT))
|
||||||
{
|
{
|
||||||
require $path;
|
require_once $path;
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
@ -114,6 +96,41 @@ protected static function load($controller)
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Execute a controller method with the given parameters.
|
||||||
|
*
|
||||||
|
* @param string $method
|
||||||
|
* @param array $parameters
|
||||||
|
* @return Response
|
||||||
|
*/
|
||||||
|
public function execute($method, $parameters = array())
|
||||||
|
{
|
||||||
|
if (static::hidden($method))
|
||||||
|
{
|
||||||
|
return Response::error('404');
|
||||||
|
}
|
||||||
|
|
||||||
|
// Again, as was the case with route closures, if the controller
|
||||||
|
// "before" filters return a response, it will be considered the
|
||||||
|
// response to the request and the controller method will not be
|
||||||
|
// used to handle the request to the application.
|
||||||
|
$response = Filter::run($this->filters('before'), array(), true);
|
||||||
|
|
||||||
|
if (is_null($response))
|
||||||
|
{
|
||||||
|
$response = call_user_func_array(array($this, $method), $parameters);
|
||||||
|
}
|
||||||
|
|
||||||
|
// The after filter and the framework expects all responses to
|
||||||
|
// be instances of the Response class. If the method did not
|
||||||
|
// return an instsance of Response, we will make on now.
|
||||||
|
if ( ! $response instanceof Response) $response = new Response($response);
|
||||||
|
|
||||||
|
Filter::run($this->filters('after'), array($response));
|
||||||
|
|
||||||
|
return $response;
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Determine if a given controller method is callable.
|
* Determine if a given controller method is callable.
|
||||||
*
|
*
|
||||||
|
|
|
@ -186,7 +186,9 @@ public function filters($name)
|
||||||
{
|
{
|
||||||
if (is_array($this->callback) and isset($this->callback[$name]))
|
if (is_array($this->callback) and isset($this->callback[$name]))
|
||||||
{
|
{
|
||||||
return (array) $this->callback[$name];
|
$filters = $this->callback[$name];
|
||||||
|
|
||||||
|
return (is_string($filters)) ? explode('|', $filters) : (array) $filters;
|
||||||
}
|
}
|
||||||
|
|
||||||
return array();
|
return array();
|
||||||
|
|
|
@ -272,7 +272,7 @@ protected function parameters($uri, $route)
|
||||||
|
|
||||||
for ($i = 0; $i < $count; $i++)
|
for ($i = 0; $i < $count; $i++)
|
||||||
{
|
{
|
||||||
if (preg_match('/\(.+\)/', $route[$i]))
|
if (preg_match('/\(.+\)/', $route[$i]) and isset($uri[$i]))
|
||||||
{
|
{
|
||||||
$parameters[] = $uri[$i];
|
$parameters[] = $uri[$i];
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue