From ea3021f3dd6c22beab5aa460f0319cd7ab8d910d Mon Sep 17 00:00:00 2001 From: Loic Sharma Date: Tue, 5 Jun 2012 22:46:35 -0500 Subject: [PATCH 1/2] Fixed bug where the profiler did not correctly put quotes around bindings --- laravel/profiling/profiler.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/laravel/profiling/profiler.php b/laravel/profiling/profiler.php index 9b6edfef..ec14004f 100644 --- a/laravel/profiling/profiler.php +++ b/laravel/profiling/profiler.php @@ -54,6 +54,8 @@ public static function query($sql, $bindings, $time) { foreach ($bindings as $binding) { + $binding = "'{$binding}'"; + $sql = preg_replace('/\?/', $binding, $sql, 1); } From f2e915f13d930f765bc918208bbefdef7155f695 Mon Sep 17 00:00:00 2001 From: Loic Sharma Date: Tue, 5 Jun 2012 22:57:56 -0500 Subject: [PATCH 2/2] Improved the way the quotes were added to the bindings. --- laravel/profiling/profiler.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/laravel/profiling/profiler.php b/laravel/profiling/profiler.php index ec14004f..73f4d4fd 100644 --- a/laravel/profiling/profiler.php +++ b/laravel/profiling/profiler.php @@ -5,6 +5,7 @@ use Laravel\Event; use Laravel\Config; use Laravel\Request; +use Laravel\Database; class Profiler { @@ -54,7 +55,7 @@ public static function query($sql, $bindings, $time) { foreach ($bindings as $binding) { - $binding = "'{$binding}'"; + $binding = Database::connection()->pdo->quote($binding); $sql = preg_replace('/\?/', $binding, $sql, 1); }