From 95bc0ae157321e928f3f8883ae8e3895fabc9333 Mon Sep 17 00:00:00 2001 From: LailaWulandarii Date: Sat, 17 Jan 2026 16:51:31 +0700 Subject: [PATCH] refactor AdditionalController and FotoController to remove commented code and improve readability --- .../Admin/AdditionalController.php | 11 ++---- app/Http/Controllers/Admin/FotoController.php | 36 ++----------------- 2 files changed, 4 insertions(+), 43 deletions(-) diff --git a/app/Http/Controllers/Admin/AdditionalController.php b/app/Http/Controllers/Admin/AdditionalController.php index 8a2a153..5313555 100644 --- a/app/Http/Controllers/Admin/AdditionalController.php +++ b/app/Http/Controllers/Admin/AdditionalController.php @@ -26,16 +26,13 @@ public function store(Request $request) 'nama' => 'nama additional', 'harga' => 'harga additional', ]); - if ($validator->fails()) { return redirect()->back() ->withErrors($validator) ->withInput() - ->with('error_modal', 'createAdd'); // Membuka modal tambah additional + ->with('error_modal', 'createAdd'); } - Additional::create($request->only(['nama', 'harga'])); - return redirect()->back()->with('success', 'Additional berhasil ditambahkan!'); } @@ -43,7 +40,6 @@ public function store(Request $request) public function update(Request $request, string $id) { $additional = Additional::findOrFail($id); - $validator = Validator::make($request->all(), [ 'nama' => 'required|string|min:3|max:100', 'harga' => 'required|numeric|min:0', @@ -58,16 +54,13 @@ public function update(Request $request, string $id) 'nama' => 'nama additional', 'harga' => 'harga additional', ]); - if ($validator->fails()) { return redirect()->back() ->withErrors($validator) ->withInput() - ->with('error_id_add', $id); // Membuka modal edit additional + ->with('error_id_add', $id); } - $additional->update($request->only(['nama', 'harga'])); - return redirect()->back()->with('success', 'Additional berhasil diperbarui!'); } diff --git a/app/Http/Controllers/Admin/FotoController.php b/app/Http/Controllers/Admin/FotoController.php index c09b361..648f987 100644 --- a/app/Http/Controllers/Admin/FotoController.php +++ b/app/Http/Controllers/Admin/FotoController.php @@ -18,8 +18,6 @@ public function index() { $foto = PaketFoto::latest()->get(); $additional = Additional::latest()->get(); - - // Kirim keduanya ke view paket-foto.index return view('admin.paket-foto.index', compact('foto', 'additional')); } @@ -48,47 +46,25 @@ public function store(Request $request) 'durasi' => 'durasi paket', 'foto' => 'foto paket', ]); - if ($validator->fails()) { return redirect()->back() ->withErrors($validator) ->withInput() - ->with('error_modal', 'createFoto'); // Agar modal terbuka otomatis saat error + ->with('error_modal', 'createFoto'); } - - // $path = null; - // if ($request->hasFile('foto')) { - // $file = $request->file('foto'); - // $filename = time() . '_' . $file->getClientOriginalName(); - // $path = $file->storeAs('img/foto', $filename, 'public'); - // } - - // PaketFoto::create([ - // 'nama' => $request->nama, - // 'harga' => $request->harga, - // 'durasi' => $request->durasi, - // 'deskripsi' => $request->deskripsi, - // 'foto' => $path, - // ]); - - // return redirect()->back()->with('success', 'Paket foto baru berhasil ditambahkan!'); - if (!$request->hasFile('foto')) { return redirect()->back() ->with('error', 'File foto tidak ditemukan!') ->withInput(); } - $file = $request->file('foto'); $filename = time() . '_' . $file->getClientOriginalName(); $path = $file->storeAs('img/foto', $filename, 'public'); - if (!$path) { return redirect()->back() ->with('error', 'Gagal upload file!') ->withInput(); } - PaketFoto::create([ 'nama' => $request->nama, 'harga' => $request->harga, @@ -96,14 +72,12 @@ public function store(Request $request) 'deskripsi' => $request->deskripsi, 'foto' => $path, ]); - return redirect()->back()->with('success', 'Paket foto baru berhasil ditambahkan!'); } public function update(Request $request, string $id) { $paket = PaketFoto::findOrFail($id); - $validator = Validator::make($request->all(), [ 'nama' => 'required|string|min:3|max:100', 'harga' => 'required|numeric|min:0', @@ -126,29 +100,23 @@ public function update(Request $request, string $id) 'durasi' => 'durasi paket', 'foto' => 'foto paket', ]); - if ($validator->fails()) { return redirect()->back() ->withErrors($validator) ->withInput() - ->with('error_id_foto', $id); // Membuka modal edit yang error otomatis + ->with('error_id_foto', $id); } - $data = $request->only(['nama', 'harga', 'durasi', 'deskripsi']); - if ($request->hasFile('foto')) { if ($paket->foto) { Storage::disk('public')->delete($paket->foto); } - $file = $request->file('foto'); $filename = time() . '_' . $file->getClientOriginalName(); $path = $file->storeAs('img/foto', $filename, 'public'); $data['foto'] = $path; } - $paket->update($data); - return redirect()->back()->with('success', 'Paket foto berhasil diperbarui!'); }