fix : issue on user not registered

This commit is contained in:
akhdanre 2025-04-27 23:59:35 +07:00
parent a797061cce
commit 73167c15f6
4 changed files with 12 additions and 8 deletions

View File

@ -7,6 +7,7 @@ from schemas import LoginSchema
from services import UserService, AuthService from services import UserService, AuthService
from exception import AuthException from exception import AuthException
from mapper import UserMapper from mapper import UserMapper
from helpers import make_response
import logging import logging
logging = logging.getLogger(__name__) logging = logging.getLogger(__name__)
@ -22,6 +23,9 @@ class AuthController:
data = request.get_json() data = request.get_json()
dataSchema = LoginSchema(**data) dataSchema = LoginSchema(**data)
response = self.auth_service.login(dataSchema) response = self.auth_service.login(dataSchema)
if response is None:
return make_response(message="User is not registered", status_code=401)
return ( return (
jsonify( jsonify(
ResponseSchema( ResponseSchema(

View File

@ -42,7 +42,6 @@ class UserMapper:
@staticmethod @staticmethod
def user_entity_to_response(user: UserEntity) -> UserResponseModel: def user_entity_to_response(user: UserEntity) -> UserResponseModel:
print(user.id)
return UserResponseModel( return UserResponseModel(
id=str(user.id) if user.id else None, id=str(user.id) if user.id else None,
google_id=user.google_id, google_id=user.google_id,

View File

@ -5,7 +5,7 @@ from google.oauth2 import id_token
from google.auth.transport import requests from google.auth.transport import requests
from configs import Config from configs import Config
from exception import AuthException from exception import AuthException
from flask import current_app from werkzeug.security import check_password_hash
class AuthService: class AuthService:
@ -36,15 +36,12 @@ class AuthService:
return self.user_repository.get_user_by_id(user_id=user_id) return self.user_repository.get_user_by_id(user_id=user_id)
def login(self, data: LoginSchema): def login(self, data: LoginSchema):
# current_app.logger.info(f"request data: {data}")
user_data = self.user_repository.get_user_by_email(data.email) user_data = self.user_repository.get_user_by_email(data.email)
# current_app.logger.info(f"user_data: {user_data}") if user_data is None:
if user_data == None:
return None return None
if user_data.password == data.password: if check_password_hash(user_data.password, data.password):
del user_data.password user_data.password = None
return user_data return user_data
return None return None

View File

@ -3,6 +3,7 @@ from repositories import UserRepository
from schemas import RegisterSchema from schemas import RegisterSchema
from mapper import UserMapper from mapper import UserMapper
from exception import AlreadyExistException from exception import AlreadyExistException
from werkzeug.security import generate_password_hash
class UserService: class UserService:
@ -17,5 +18,8 @@ class UserService:
if existData: if existData:
raise AlreadyExistException(entity="Email") raise AlreadyExistException(entity="Email")
encrypted_password = generate_password_hash(user_data.password)
user_data.password = encrypted_password
data = UserMapper.from_register(user_data) data = UserMapper.from_register(user_data)
return self.user_repository.insert_user(data) return self.user_repository.insert_user(data)